SpongePowered / SpongeForge

A Forge mod that implements SpongeAPI
http://www.spongepowered.org/
MIT License
1.14k stars 306 forks source link

Unexpected spawn location using modded portals #2025

Closed waggz81 closed 6 years ago

waggz81 commented 6 years ago

I am currently running

Logs from sponge 2920: https://gist.github.com/waggz81/6ff541d250678201d66a3e988235207f

ProsperCraft commented 6 years ago

We are having this same problem with the Caverns portals.

People keep getting killed by ending up inside the ground.

3TUSK commented 6 years ago

I am experiencing the same issue when entering Twilight Forest with the following setup:

Entering twilight forest will throw player entity into mid-air, and no portal for way back would be created; if manually create one and step into it, player will be teleported to the same coordinate within overworld.

With info provided by OP, I suspect that https://github.com/SpongePowered/SpongeCommon/commit/36a7746d9da49f769b19999d592d016970534e9a is the cause (which was introduced in build 2020), however I haven't conduct further researches/debugging and thus cannot be 100% sure.

Edit I: add OS and JRE info.

liach commented 6 years ago

@3TUSK You are for sure wrong. That commit only exists on the bleeding branch while you test with a stable-7 build.

phit commented 6 years ago

@liach https://github.com/SpongePowered/SpongeCommon/commit/38fdfdcb9bc631ade7175bdec72d2198a798044b no?

liach commented 6 years ago

Oh. that's a cherry pick, so that first commit isn't shown to be on stable 7

ProsperCraft commented 6 years ago

May want to change the topic to - Unexpected spawn location when using any mods portals to other dims.

We are having problems with Caverns 2, Twilight, and changing dims with the signpost mod.

phit commented 6 years ago

changed the title, I can confirm this happens with pretty much any kind of modded portal

ProsperCraft commented 6 years ago

Tested - Fixed the issue with Caverns 2 thank you!