search

SpongePowered / SpongeForge

A Forge mod that implements SpongeAPI
http://www.spongepowered.org/
MIT License
1.14k stars 306 forks source link

EnderIO Dark Steel Armor #2320

Open batteryhun78 opened 6 years ago

batteryhun78 commented 6 years ago

I am currently running

Issue Description https://github.com/SleepyTrousers/EnderIO/issues/4782

Issue Description: 1.12.2-5.0.29 version of EnderIO, and any Version of Sponge Forge (I did test older) makes this problem, where essentially after putting the "Sponge Forge" "mod" into the mods folder in the server, loading it, does this problem [Tested on Direwolf 2.1.0 Server]. What's the problem exactly? EnderIO Armors, so Dark Armor and the Ender Armor With my words, it looks like, something happening with the "absorbtion" where if it's empowered and fully charged, you less likely to get damage from mobs because of the absorbtion when your suit is powered, as it is written. When the two "mods" are present, something happens with these armors, and I got no protection at all. As I tested, Zombies does the same damage as if I did not wear anything. I have already asked this on Sponge [First Link] but we did not get a definite conclusion. --> [Second Link] <--- This is the log, and the debug file, from my test server, where the two "mods" were together and where the problem occured. [Direwolf20 1.12, 2.1.0]

I tested, what if I delete all the other mods. |1| Only EnderIO [EnderIO-1.12.2-5.0.29] and EnderCore EnderCore-1.12.2-0.5.35 Without Sponge--> Works |2| EnderIO [EnderIO-1.12.2-5.0.29], EnderCore [EnderCore-1.12.2-0.5.35] and Sponge [spongeforge-1.12.2-2705-7.1.0-BETA-3320] With Sponge --> Doesn't work [Third link] Contains debug and log file

What happens: Something with the "damage" absorbtion

What you expected to happen: that the armor works the way it should be, and as it is written. Steps to reproduce: Put any SpongeForge version into the mods folder Start the Server Test if the absorbtion works when the armor is powered. Without Sponge--> Works | With Sponge --> Doesn't work ... Affected Versions (Do not use "latest"): EnderIO: EnderIO-1.12.2-5.0.29 EnderCore: EnderCore-1.12.2-0.5.35 Minecraft: 1.12 Forge: 14.23.4.2732 Sponge: spongeforge-1.12.2-2705-7.1.0-BETA-3320, 3307 - but looks like any version of Sponge will create the same issue. Your most recent log file where the issue was present: |1| https://imgur.com/a/s8q9hBw |2| https://drive.google.com/open?id=1XQTjknLIC9bIA2A26-F2fFAmSlQyUQsX |3| https://drive.google.com/open?id=1nzyNU40OX5H2QTdtKCy6nNl6W8ds1ZFf

|1| https://imgur.com/a/s8q9hBw |2| https://drive.google.com/open?id=1XQTjknLIC9bIA2A26-F2fFAmSlQyUQsX |3| https://drive.google.com/open?id=1nzyNU40OX5H2QTdtKCy6nNl6W8ds1ZFf

gabizou commented 6 years ago

Because there's a lot of confusion going around, can I get a very precise explanation on how to reproduce the issue? What steps, what items specifically and how to test the items work without sponge forge?

tyler489 commented 6 years ago

Sorry i misread the issue. i thought this was a different issue... which was not reported yet and as such i just opened a new issue for it (#2325)

I have removed my confusing statements from this thread This was origionally reported as https://github.com/SleepyTrousers/EnderIO/issues/4782 on enderio's github

batteryhun78 commented 6 years ago

@gabizou Simply, get a simple server. I used Direwolf 2.1.0. Without sponge forge[any version] the modpack-EnderIO works fine. But I need some plugins to my server, so let's put the sponge forge into the mod folder, where it should be. After this act, I was wearing my armor from EnderIO and realized that it doesn't "work" because i take two heart damage from skeleton, one and a half from zombie, it looked like the "apsorbtion" didn't work((The suit was "empowered")), but after removing sponge forge, everything was fine.

Currently there's two armor type from EnderIO, the Dark one, and the Ender one. - Both does the same when I take damage and sponge forge is in present. If I fall into the lava, with wearing the suit. I'm instantly dead, like I wasn't wearing any armor.

There are some ability in EnderIO armors that you can use, like elytra,nightvision,speed, doube jump... These things works fine, but the armor "itself" doesn't protect at all, when the Sponge Forge is in present.

Removing Sponge Forge --> Everything works fine

tyler489 commented 6 years ago

Note Absorption is what the armor uses its energy stored not the potion effect

batteryhun78 commented 6 years ago

2018-07-19_09 09 50

For example. If I'm wearing the boots, the fall damage reducing works, so it takes energy from the boots, so i don'take damage. But when we talk about "protection" like getting hit be arrow/zombie hits, the armor doesn't work

ryantheleach commented 6 years ago

https://github.com/SleepyTrousers/EnderIO/blob/b6ef960f0d4f7f8a06516f089107fb79a2a0d0d7/enderio-base/src/main/java/crazypants/enderio/base/item/darksteel/ItemDarkSteelArmor.java#L345 For relevant ender IO code.

Zidane commented 5 years ago

Can you retest with the latest SF? I think this was fixed.

Kantets commented 5 years ago

The problem still remains relevant on SpongeForge: 1.12.2-2838-7.1.7-RC3896

HenryLoenwind commented 4 years ago

I think this should be labeled "type: forge incompatibility", not "type: mod incompatibility". Ender IO isn't doing anything special with the "damage to player" part.

gabizou commented 4 years ago

Please don't just close an issue without a response or reason why...

I think this should be labeled "type: forge incompatibility", not "type: mod incompatibility". Ender IO isn't doing anything special with the "damage to player" part.

We don't have a label for that. In a sense, it's an incompatibility with forge as a mod in itself.