SpongePowered / SpongeForge

A Forge mod that implements SpongeAPI
http://www.spongepowered.org/
MIT License
1.14k stars 306 forks source link

Deadlock with Pistons #2389

Closed Shybella closed 5 years ago

Shybella commented 6 years ago

I am currently running

Issue Description

Random deadlock with pistons that keeps happening. download download

Unable to reproduce or find a way. Asking for method of additional debugging or potential fix. I can try to provide more information if needed.

Thank you.

Shybella commented 6 years ago

I've not had another occurrence with this. Although, I think it may have something to do with Chisel n Bits and pistons.

Shybella commented 6 years ago

Happened again download

Is there anything that can be done? Running SF: 3414

Shybella commented 6 years ago

download

SF: 3422

gabizou commented 6 years ago

You have pistons being cancelled, likely by protections. Nothing really going wrong here on sponge's side. @bloodmc thoughts? I think for some reason we might be capturing blocks on piston movement again (or this is the block update for pistons). I'll have to triple check how they flow again.

I would try to find out where the mass amount of pistons are that are scheduling so many updates.

Shybella commented 6 years ago

Thank you for looking into this, gabi.

I do believe it's something to do with GP and pistons. I was able to reproduce this by chance using 3 pistons to push some Chisel n Bits stone inside of a claim.

Shybella commented 6 years ago

This is becoming a month old and no avail yet.

I've allowed pistons to not be tracked by GP and still happening.

Shybella commented 5 years ago

As this has not reoccurred in the last 3 weeks, I have my suspicions with either malformed GP claim data or permission issues with piston:extensions being blocked by GP. Could also be caused by Redstone Panda being enabled. Those are the 3 things that has changed, and has gone away because of one of those changes.

I am closing this out if this returns, I'll reopen with more information if it does return