gabizou
commented
6 years ago I think I have an idea of what's happening:
During world gen, there are a few world generation events thrown on the world generation event bus, and while I haven't considered needing to ignore the block changes occurring due to those event listeners, we might have to specifically check if this is either the ore gen bus or another event bus that we "shouldn't track" due to world generation. Or, simply put: add a phase state check if this is world gen and then ignore adding event listener phase states which can cause bleeding into normalized "non-world gen" logic to occur, in this case neighbor notification block tracking.
I'll fiddle with this but I have a very big question: Is this easy to reproduce? And if so, how do I reproduce it without launching 100s of mods in a mudpack?
phit
AsuraTakun
I am currently running
Mods (175): Minecraft, Minecraft Coder Pack, Forge Mod Loader, Minecraft Forge, SpongeAPI, SpongeForge, AI Improvements, Advanced Chimneys, AgriCraft, Ambidextrous, AppleCore, Aquaculture, Aquatic, Aroma1997Core, AromaBackup, AromaBackuprecovery, Astikoor, AutoRegLib, Bad Wither No Cookie! Reloaded, Bailey's Dailies, Baubles, Baubley Heart Canisters, Bed Bugs, Better Builder's Wands, Better Fishing, Better Records, Better Than Mending, Better With Engineering, Better With Mods, Better with Addons, BiblioCraft, Bibliotheca, Blood Debug, Carry On, Chameleon, Chest Transporter, Chickens, ChinjufuMod, Chisel, CoFH World, CodeChicken Lib, Cooking for Blockheads, Coralreef, CosmeticArmorReworked, CosmeticArmorReworked Integration for TombManyGraves2, CraftTweaker JEI Support, CraftTweaker2, Craftable Horse Armour [CHA&S], Creeper Confetti, Cucumber Library, Culinary Construct, Death Quotes, Dimensional Doors, Doggy Talents, DungeonTactics, Dynamic Surroundings, Dynmap, DynmapBlockScan, E-Vaporate, EnderStorage, Engineer's Doors, Extra Alchemy, Fairy Lights, Familiar Fauna, FannyPack, Farming for Blockheads, Fast Leaf Decay, Faster Ladder Climbing, Fence Overhaul, FoamFix, FoamFixCore, Forge Endertech, Friendly Fire, Garden Stuff, Hardcore Buoy, Harvest, Hatchery, HeatAndClimateASM, HeatAndClimateLib, HeatAndClimateMod, HelpFixer, Horizontal Glass Panes, Horse Tweaks, Immersive Engineering, Immersive Petroleum, Immersive Railroading, Immersive Tech, ImmersiveFood, Improved Backpacks, InfinityLib, Inspirations, Iron Backpacks, JourneyMap, Jukebox Mod, Just a Few Fish, Landlust, Lava Dynamics, Level Up! Reloaded, LibEx, LunatriusCore, MTLib, MalisisCore, MalisisDoors, Mantle, Mega Loot, MetalChests, Millenaire, MineColonies, Moar Boats, Mod Support, Mod Tweaker, Moon's Core, More Chickens, Morpheus, Multi-Beds, NetherEx, NetherPortalFix, No Mob Spawning on Trees, NoMoreRecipeConflict, Not Enough Roofs, NotEnoughIDs, Nutrition, Openable Windows, Pam's HarvestCraft, PamSimpleHarvest, Perfect Spawn, Pet Bat, PiTweaks, Pickle Tweaks, Pinkly Sheep, PizzaCraft, Placebo, Potion Core, Prefab, Primitive Mobs, Pumpkin Carving, Quality Tools, Quark, Refined Relocation, Repurpose, Roguelike Dungeons, Roost, Rustic, Sampling Performance Profiler, ServerSync, Shadowfacts' Forgelin, ShetiPhian-Core, Smoke Wheat Everyday, SteamWorld, Storage Drawers, Super Blocks 'n Buckets, Taco Tuesday, TeaStory, Team Up, TerraCart Reloaded, Terraqueous, TickProfiler, To the Bat Poles!, TombManyGraves2 API, Track API, TrashSlot, Unique Crops, V-Tweaks, Vanilla Food Pantry, Vanilla Tweaks, Vein Miner, ViesCraft, Wall-Jump!, Waystones, What Are We Looking At, World Utils, WorldEdit, Zoo and Wild Animals Mod: Rebuilt, iChunUtil, mxTune
Issue Description Player generated a new chunk that ended up causing a stack overflow initially (line 63414), followed shortly by a stack corruption (line 64446), then finally the Capture Block Change fallout (starting line 89144). The capture block change continued until I closed the server manually. The initial stack overflow was possibly caused by chisel, but the rest of it does not list a specific mod.
2018-08-24-7.log.gz (The file was too large for gist)