search

SpongePowered / SpongeForge

A Forge mod that implements SpongeAPI
http://www.spongepowered.org/
MIT License
1.14k stars 306 forks source link

Crash when updating from 3616 to 3666 #2706

Closed d4julian closed 5 years ago

d4julian commented 5 years ago

I am currently running

Sponge/Forge version: Minecraft Forge: 14.23.5.2831 SpongeForge: 1.12.2-2768-7.1.6-RC3666 Sponge: 1.12.2-7.1.6-SNAPSHOT SpongeAPI: 7.1.0-b2736425 Minecraft: 1.12.2

Sky Factory 4 Modpack

Plugins (38): Minecraft, Minecraft Coder Pack, SpongeAPI, Sponge, AuraBlockLimit, AurionsVoteListener, AutoReset, BetterChunkLoader, BungeeTabListPlus-SpongeBridge, Buycraft, CarrotShop, CatClearLag, Command-Blocker, CommandUtils, Dirt keepInventory, Dirt-Join-Leave-Messages, DirtCrashFailsafe, DirtRanks, DirtRespect, EconomyLite, GriefPrevention, Holograms, HuskyCrates, HuskyUI, LuckPerms, MMCReboot, MMCRestrict, MagiBridge, NuVotifier, Nucleus, OnlineBroadcast, PixelAutoMessages, PlayerDataReset-Plugin, Prism, RankUpper, SkyClaims, UltimateChat, spark
Mods (193): Minecraft, Minecraft Coder Pack, Forge Mod Loader, Minecraft Forge, SpongeAPI, Sponge, Advancement Book, Animal Crops, Apotheosis, AppleCore, AppleSkin, Applied Energistics 2, Aroma1997Core, Astral Sorcery, B.A.S.E, BNBGamingLib, Backups, Barrels, Drums, Storage & More, Baubles, Bed Patch, BiblioCraft, BnBGamingCore, Bonsai Trees, Bookshelf, Building Gadgets, Caliper, Calm Down Zombie Guy, Ceramics, Chargers, ChineseWorkshop, Chisel, Chisels & Bits, Click Machine, CoFH Core, CoFH World, CodeChicken Lib, ComPatchedStorage, CommonCapabilities, Compact Machines 3, CompactStorage, Construct's Armory, ContentTweaker, Cooking for Blockheads, CraftTweaker JEI Support, CraftTweaker2, Cucumber Library, Culinary Construct, Custom Mod Rejection Messsage, Cyclic, Cyclops Core, Dark Utilities, Deep Mob Learning, Dimension Stages, Elevator Mod, Ender Crop, Ender Utilities, EnderCore, EnderStorage, Extended Crafting, Extra Cells 2, Extra Cells Patch, Farming for Blockheads, FastFurnace, FastWorkbench, Fence Overhaul, FindMe, Flux Networks, FoamFix, FoamFixCore, Forge Microblocks, Forge Multipart CBE, Forgiving Void, Game Stages, Guide-API, Headcrumbs, Horse Power, Hunting Dimension, HydroGel, InControl, Industrial Foregoing, Inspirations, Integrated Dynamics, Integrated Tunnels, IntegratedDynamics-Compat, IntegratedTunnels-Compat, Iron Jetpacks, Item Stages, Just Enough Items, KleeSlabs, Limitless Structure Blocks, MCMultiPart, MTLib, MalisisCore, MalisisDoors, Mantle, MatterOverdrive: Legacy Edition, McJtyLib, Mekanism, MekanismGenerators, Mercurius, Minecraft Multipart Plugin, Mob Stages, Mod Tweaker, ModPack Basic Tools, ModPack Utilities, More Buckets, More Cauldrons, Mystcraft, Mystical Agradditions, Mystical Agriculture, NuclearCraft, OG Dragon+, OpenComputers, OpenComputers (Core), OpenComputers Xnet Driver, OreExcavation, Parabox, Pickle Tweaks, PigUtils, Pipe Master 2000, Placebo, PortalGun, Practical Logistics 2, Prestige, Primitive Crafting, ProjectE, RFToolsPower, Ranged Pumps, Real Filing Cabinet, RecipeStages, Redstone Flux, Resource Hogs, Rustic, Sampling Performance Profiler, Shadowfacts' Forgelin, Simple Generators, Simple Storage Network, Sky Grid, SkyBonsais, Slab Machines, SlimyBoyos, Snad, SonarCore, SpongeForge, Squeezer Patch, Statues mod, Stuff A Sock In It, Super Sound Muffler, Surge, SwingThroughGrass, Sync, TallGates, TelePastries, Tesla Core Lib, Tesla Core Lib Registries, The Lost Cities, The Twilight Forest, The Weirding Gadget, Thermal Dynamics, Thermal Foundation, Thermal Innovation, TickProfiler, Tinkers Tool Leveling, Tinkers' Complement, Tinkers' Construct, Tiny Progressions, TogetherForever, Topography, TorchMaster, Translocators, Tree Growing Simulator 2016, Triumph, Twitchcrumbs, Universal Modifiers, Valkyrie Lib, ViesCraft, Waddles, Waila, Waila Stages, Wall-Jump!, What Are We Looking At, Wither Crumbs, World Utils, WorldEdit, XL Food Mod, XNet, YNot, Yoyos, ZenStages, bouncy_creepers, mob_grinding_utils, sky_orchards, uppers

Issue Description

Crash report when updating from SpongeForge 3616 to 3666. I loaded back in 3616 and removed the block manually, then loaded in 3666 and server started up successfully.

d4julian commented 5 years ago

Getting crash reports like these every few minutes:

gabizou commented 5 years ago

Can you add -Dlegacy.debugClassLoading=true and -Dlegacy.debugClassLoadingSave=true to launch and zip up the CLASS_LOADER_TEMP folder that gets generated? Need to see if there's some transformation going on that's preventing the phase contexts being pushed.

d4julian commented 5 years ago

Sorry, I've been a bit busy. I'll get it done tomorrow :)

d4julian commented 5 years ago

This is still present on RC3680.

Google Drive link to CLASS_LOADER_TEMP Crash Report

Keaton1188 commented 5 years ago

Also had the same issue, but I've stuck with build 3616 because it seems the most stable atm lol

gabizou commented 5 years ago

@d4julian requested access to the classloader zip file.

gabizou commented 5 years ago

Found the issue: When maximum processing has been reached for neighbor notifications, we don't switch into the PhaseState, leading to issues where the PhaseTracker tries to close out other phase states which then causes cascading failures of other phase states (whether they're unwinding, parented neighbor notifications, packet processing, tick processing, etc.). Will hopefully either have fixed both the recursive nature of neighbor processing in the build including this commit, and then lastly, the actual issue causing cascading failure with this commit ultimately leading to the crash due to this line specifically.