Dynamic tree spam (100m server log)

SpongePowered / SpongeForge

A Forge mod that implements SpongeAPI

http://www.spongepowered.org/

MIT License

1.14k stars 306 forks source link

Dynamic tree spam (100m server log) #2777

Open Raycoms opened 5 years ago

Raycoms commented 5 years ago

Minecraft : 1.12.2
SpongeAPI : 7.1.0-3fdbf299
Sponge : 1.12.2-7.1.6-SNAPSHOT
SpongeForge : 1.12.2-2825-7.1.6-RC3713
Minecraft Forge : 14.23.5.2836

Operating System: Linux debian
Plugins/Mods: https://minecraft.curseforge.com/projects/minecolonies-testpack Issue Description

We're getting huge logs with sponge and dynamic trees which lag our server significantly (IO)

https://gist.github.com/Wissi/7a1db435d128d13f21f36980f021e027

phit commented 5 years ago

previous issue with the same mod https://github.com/SpongePowered/SpongeForge/issues/2729

Zidane commented 5 years ago

    protected MoreObjects.ToStringHelper getPrettyPrinterStringHelper() {
        return MoreObjects.toStringHelper(this)
            .add("type", this.tileType.getId())
            .add("world", this.world.getWorldInfo().getWorldName())
            .add("pos", this.pos);
    }

One of these is null (tileType, world, world.getWorldInfo(), or pos). None of which is good..

gabizou commented 5 years ago

Need some way to reproduce. The exception is masking what blocks are failing to be pruned etc.

Sir-Will commented 5 years ago

Same error here but without thaumcraft. It did throw the first error and then kept spamming the other ones.

The block Packet: CPacketPlayerDigging{position=BlockPos{x=-257, y=85, z=1786}, facing=up, action=STOP_DESTROY_BLOCK} from the log is a ArmorPlus Workbench.

I tried reproducing it but so far I couldn't.

https://gist.github.com/Sir-Will/6cd5d991af5f35d4cda62fe92bbb3159

(spongeforge-1.12.2-2825-7.1.7-RC3768, armorplus-1.12.2-11.24.0.60)

Sir-Will commented 4 years ago

Any news on this? I'm getting these errors again with spongeforge-1.12.2-2838-7.2.4-RC4059