Lag in PhaseContext.close?

LemADEC commented 5 years ago

I am currently running

SpongeForge version: 1.12.2-2838-7.1.7-RC3909
Forge version: 14.23.5.2836
Java version: 1.8.0_212/64-bit
Operating System: Linux
Plugins/Mods: Mods (132): Minecraft, Minecraft Coder Pack, Forge Mod Loader, Minecraft Forge, SpongeAPI, Sponge, AE Net Vis Tool, AE2 Stuff, AI Improvements, Advanced Fishing, Advent Of Ascension, Angel of Vengeance, Apotheosis, AppleSkin, Applied Energistics 2, Attribute Fix, BD Lib, Bauble Wings, Baubles, Baubley Heart Canisters, Better Than Mending, Blockcraftery, Botania, Brandon's Core, Building Gadgets, CC: Tweaked, CC: Tweaked, Chance Cubes, Chisel, CoFH Core, CoFH World, CodeChicken Lib, CraftTweaker JEI Support, CraftTweaker2, CreativeCore, CreativeCoreDummy, Cuisine, CustomNPCs, Cyberware, Cyclops Core, ElecCore, ElecCoreLoader, Elevator Mod, EvilCraft, EvilCraft-Compat, Extreme Reactors, FastFurnace, FastWorkbench, FlashFyre's Enchantments, FoamFix, FoamFixCore, Guide-API, Hexxit Gear, ICBM-Classic, InControl, Inventory Tweaks, JAOPCA, JourneyMap, Just Enough Dimensions, Just Enough Items, Kiwi, LLibrary, LagGoggles, LittleTiles, LittleTilesCore, Login Shield, MTLib, MachineMuse's Modular Powersuits, Malisis Advert, MalisisCore, Mantle, Mekanism, Mekanism: Generators, Mekanism: Tools, MetalChests, Metallurgy 4: Reforged, MineTraps, MmmMmmMmmMmm, Moar Tinkers, Mod Tweaker, Mystical Lib, Mystical Wildlife, NuclearCraft, Numina, OMLib, Open Modular Passive Defense, Open Modular Turrets, OreDictInit, PackCrashInfo, Patchouli, Phosphor Lighting Engine, Placebo, Prodigy Tech, Quick Leaf Decay, RandomPatches, RandomTweaks, Redstone Flux, Reliquary, Ruins Mod, SG Craft, Shield Parrying, Simple Inventory sorting, Snad, Spartan Shields, Spartan Weaponry, SpongeForge, Subterranean Waters, SwingThroughGrass, TBone, TOP Addons, TamModized, Techguns, Techguns Core, Tell Me, The Lost Cities, The One Probe, Thermal Dynamics, Thermal Expansion, Thermal Foundation, Tinker's JEI, Tinkers Tool Leveling, Tinkers' Construct, Tool Belt, Underground Biomes, WarpDrive, WarpDriveCore, Wings, Woot, WorldEdit, Worley's Caves, WrapUp, Zero CORE

Plugins (19): Minecraft, Minecraft Coder Pack, SpongeAPI, Sponge, AntiWDL, BetterChunkLoader, Broadcast, CatClearLag, ClearMob, Enjin Minecraft Plugin, GriefPrevention, LuckPerms, MCClans, Nucleus, Nucleus API, Pieconomy, Server Backup, WrapperPing, spark

Issue Description After updating spongeforge from RC3900 to RC3909, lag is reported in console. According to profiler, PhaseContext.close is taking 25% of CPU. TileEntityTickContext.source is taking 10% of CPU. checkIfTileHasActiveChunk is taking 5% of CPU. It could be related to players using WarpDrive force fields (i.e. lots of tile entities).

https://sparkprofiler.github.io/#DuVGJa69n3

gabizou commented 5 years ago

Need a yourkit or visualvm profiling doc. The spark profiler doesn't provide enough information for me to point where there's potentially problems.

LemADEC commented 5 years ago

I was able to grab a short profiling while the server is frozen in that PhaseContext.close() call: That's in SMP with SpongeForge: 1.12.2-2838-7.1.7-RC3924 Minecraft Forge: 14.23.5.2836 JVM: 1.8.0_212/64-bit (Oracle Corporation) OS: Linux (3.14.32-xxxx-grs-ipv6-64/amd64) I suspect it happens when a force field collapse (removing lots of tile entities in a single tick)

WarmRoast Sponge#2967 2019-09-22a.zip (actually a 7-zip archive)

LemADEC commented 4 years ago

Any further information needed?

SpongePowered / SpongeForge

Lag in PhaseContext.close? #2967