search

SpongePowered / SpongeForge

A Forge mod that implements SpongeAPI
http://www.spongepowered.org/
MIT License
1.14k stars 306 forks source link

After 25 points of armor, we become invulnerable to incoming damage and PVP. #3140

Open davizon200 opened 4 years ago

davizon200 commented 4 years ago

I am currently using spongeforge-1.12.2-2768-7.1.6-RC3657

Not using latest version due to us using Forge 1.12.2-14.23.5.2768 for mods only in this version... (And an issue of overspawning of bosses in twilight forest that was solved by this version of spongeforge)

-Mods (76): Minecraft, Minecraft Coder Pack(B, Forge Mod Loader(B, Minecraft Forge(B, SpongeAPI(B, Sponge(B, Aether Continuation(B, Aether Legacy(B, Animal Bikes(B, Anvil Patch - Lawful(B, Applied Energistics 2(B, Astral Sorcery(B, Bauble Wings(B, Baubles(B, Better Diving(B, Better Merchants(B, Better Questing(B, Biomes O' Plenty(B, Bookshelf(B, Botania(B, Champions(B, Chisel(B, Chroma Mod(B, Corail Tombstone(B, CosmeticArmorReworked(B, CosmeticArmorReworked Integration for TombManyGraves2(B, CreativeCore(B, CreativeCoreDummy(B, CustomNPCs(B, Damage Control(B, Damage Indicators Mod(B, Decocraft(B, DrZhark's CustomSpawner(B, DrZhark's Mo'Creatures Mod(B, Effortless Building(B, Elevator Mod(B, Erebus(B, Fence Jumper(B, FoamFix(B, FoamFixCore(B, Foamflower(B, Glacidus(B, Grand Economy(B, HideNames(B, Hunting Dimension(B, Ice and Fire(B, Iron Backpacks(B, JourneyMap(B, Just Enough Items(B, Kinetic Clear Lag(B, LLibrary(B, Leather Works(B, Material Changer(B, Mob Properties Randomness(B, Morph(B, Morpheus(B, Player Revive(B, Psychonautic(B, Reap Mod(B, Roguelike Dungeons(B, Rustic(B, SecurityCraft(B, Seltak's Weapon Pack(B, Simple Harvest(B, SpongeForge(B, Standard Expansion(B, The Dimensions Mod(B, The Twilight Forest(B, TirphyCraft(B, Tropicraft(B, Weapon Mod | Gladiation Edition(B, Weapons Mod | Kronos Edition (Greek Mythology)(B, Wings(B, Wither Dimension(B, WorldEdit(B, iChunUtil(B

Plugins (8): Minecraft, Minecraft Coder Pack(B, SpongeAPI(B, Sponge(B, CatClearLag(B, Chest Refill(B, LuckPerms(B, Nucleus(B

Issue Description

This does NOT happen in singleplayer.. only in server. After wearing (modded from what i can tell) armor that passes 25 points of armor... we become invulnerable to hits, and PVP, but not to fire and fall damage for example... I got some support from a dev in the sponge discord and he gave me a command to turn my helmet into a helmet with 25 armor points, and later 50 points, and i was getting damage with 50 armor points... (which i believe cap is 30). For example all armors from "Ice and Fire" mod make me invulnerable, but as i start removing pieces of armor from it, i start taking damage... If i wear 2 pieces of diamond vanilla armor, and 2 pieces of dragonsteel (example) and i pass 25 armor points i STILL become invulnerable, so its not only mod armors in that sense...

-I first tried removing all plugins except sponge, since it only happened server side: did NOT solve the issue... -Then i tried removing sponge forge... It DID Solve the issue... -Then i tried removing half the mods we have (With sponge installed again), Did NOT solve the issue. -Then i tried removing other half of the mods, Did NOT solve the issue.

I tried various versions of sponge forge as well with no luck... (i tried like 10 different versions)

Crash-lol / log

No Logs to paste with my issue...

I will add more information as i test more... but as of right now... removing spogneforge seems to be the only solution :(

clienthax commented 4 years ago

I'm guessing this may be related to something in here, is there a ice and fire side issue to track this?

Also does this happen on the latest edition of spongeforge?

https://github.com/SpongePowered/SpongeCommon/blob/00f5e56506b1bf9f52489a453443c215473a0534/src/main/java/org/spongepowered/common/event/damage/DamageEventHandler.java#L83

davizon200 commented 4 years ago

i cannot use the latest edition,

it is not caused by ice and fire (im guessing), since doesnt happen in singleplayer, and this issue occurs with amror from other mods...

that DOES look like exactly whats going on here...

How can i access that?

MySQL iin sponge?

clienthax commented 4 years ago

Why are you unable to use the latest edition?

davizon200 commented 4 years ago

From what i remember, i believe it crashed!

Sent via the Samsung Galaxy S8 Active, an AT&T 4G LTE smartphone Get Outlook for Androidhttps://aka.ms/ghei36

From: clienthax notifications@github.com Sent: Sunday, April 26, 2020 1:04:06 AM To: SpongePowered/SpongeForge SpongeForge@noreply.github.com Cc: davizon200 davizon200@hotmail.com; Author author@noreply.github.com Subject: Re: [SpongePowered/SpongeForge] After 25 points of armor, we become invulnerable to incoming damage and PVP. (#3140)

Why are you unable to use the latest edition?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/SpongePowered/SpongeForge/issues/3140#issuecomment-619452160, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AO5AYQIRFP2PXUBEPBZ3GD3RONT6NANCNFSM4MNRLRUA.

clienthax commented 4 years ago

Well you need to figure out why it crashed, and run the latest version otherwise you won't be able to use a fix when it comes out anyway ;)

davizon200 commented 4 years ago

okay i can try and figure this out but... you're telling me there is no solution to this???

I can't just access the SQL and edit it?

clienthax commented 4 years ago

I'm not sure where you are getting SQL from here? But obviously you would need to be able to update to the build where / when this is fixed wouldn't you?

davizon200 commented 4 years ago

that is true, is there currently a version where this is fixed then???