search

SpongePowered / SpongeGradle

Handy gradle utilities for the various gradle projects of SpongePowered
MIT License
21 stars 16 forks source link

Don't add mavenLocal #16

Closed BrainStone closed 2 years ago

BrainStone commented 6 years ago

I've noticed that this plugin is adding mavenLocal() to the reositories (https://github.com/SpongePowered/SpongeGradle/blob/master/src/main/groovy/org/spongepowered/gradle/plugin/SpongePluginPlugin.groovy#L49)
This is an issue because if maven is being used too, there often is the chance that in mavenLocal the source and javadoc artifacts are missing. Keep in mind that that is where maven caches its downloaded artifacts. Additionally there might be issues with snaptshots, as they aren't updated in mavenLocal.

stephan-gh commented 6 years ago

The main problem is that since SpongeGradle adds its repositories first, it's rather ugly to add in mavenLocal() as the first repository manually. It's possible, but not pretty.

However, I think I mainly added it because @kashike asked me to do it. See https://github.com/SpongePowered/SpongeGradle/commit/48933f970b00c916e5f960661e9b0cb65ecc0834

BrainStone commented 6 years ago

Removing mavenLocal again is just as ugly though.

And since it seems that adding repos through a plugin can be a real hassle, I think it's worth a thought to not add any repos at all.

zml2008 commented 2 years ago

This issue is no longer applicable to SpongeGradle 2.0.0+