Update AutoRenamingTool, use neoforged version

SpongePowered / VanillaGradle

A toolchain for Minecraft: Java Edition that builds a workspace to interact with the game using the official mappings provided to the public by Mojang Studios.

MIT License

91 stars 18 forks source link

Update AutoRenamingTool, use neoforged version #141

Closed kennytv closed 5 months ago

kennytv commented 5 months ago

This migrates to neoforged's version of AutoRenamingTool. Where Forge's version hasn't really had many changes in a long time, this takes off a solid 15 seconds of the 1 minute and 30-ish second total I get on a Windows machine for a full decompile of joined Minecraft code

kennytv commented 5 months ago

Though it looks like Sponge's maven repo doesn't (fully?) mirror neoforged, it should include cli-utils and gson-io so the additional repo can be removed here and when using VG

zml2008 commented 5 months ago

Thanks for the PR! If we were to use Neo's forks of these tools (and mergetool), we'd want ART and all its deps on Central, not just the partial publication that currently exists. For now, there are larger design questions that should be considered rather than hopping from fork to fork -- like, can VG's pipeline be improved so it's not tied to any specific remapper -- so for now I'm afraid we won't be accepting this PR.