search

SpongePowered / VanillaGradle

A toolchain for Minecraft: Java Edition that builds a workspace to interact with the game using the official mappings provided to the public by Mojang Studios.
MIT License
87 stars 18 forks source link

Minecraft being shaded when it was not previously #70

Closed jpenilla closed 9 months ago

jpenilla commented 2 years ago

After https://github.com/SpongePowered/VanillaGradle/commit/bc3c2a926dfd29e13b660f7a884b7f24dcdeb487 and https://github.com/SpongePowered/VanillaGradle/commit/cfa6638a3cb05e5db64954ed42cc80777b104a5d, Minecraft is now being included into my shadow jar where it wasn't before. Project in question can be seen at https://github.com/jpenilla/squaremap/tree/master/sponge, I've simply pinned an old snapshot in gradle/libs.versions.yml to get it to build properly for now.

jpenilla commented 2 years ago

This issue was originally tested with Minecraft 1.18.2 and 1.19, testing Minecraft 1.16.5, it seems like Minecraft is shaded before and after the aforementioned commits. 0.2 functions properly for 1.16.5.