Fixing #327 (from https://github.com/SpoonX/aurelia-authentication/is…

bondib commented 7 years ago

…sues/327)

RWOverdijk commented 7 years ago

Hello! And thanks for contributing.

I have some requests:

Please change your subject to be a short explanation of what you changed. In the description you can then use something like: fixes #327, so github can automatically link to the issue, and close it on merge.
Please don't do a build / version bump. There's a deploy toolchain that does all of this stuff for us. That makes sure that the PR diff stays readable and minimal, and makes for less merge conflicts.
Please make your commit messages follow our contributing guidelines.

For the rest the fix looks fine to me, thanks again!

bondib commented 7 years ago

Hi. Sorry, I didn't notice the pull request took the build stuff. I did this for us internally as I needed to fix the bug in our application and I needed a release for that... The intention was only to modify the code, not the build related things...

Anyways, I will create a new pull request according to your request.

RWOverdijk commented 7 years ago

@bondib No sorry needed. I'm glad you pointed this out and proposed a fix to begin with. :)

SpoonX / aurelia-authentication

Fixing #327 (from https://github.com/SpoonX/aurelia-authentication/is… #328