SpoonX / aurelia-authentication

Authentication plugin for aurelia.
http://aurelia-authentication.spoonx.org
MIT License
90 stars 60 forks source link

fix(Update aurelia-authentication.js): Changed to this.authentication.updateAuthenticated() to this.updateAuthenticated() #378

Closed vincentw56 closed 6 years ago

vincentw56 commented 6 years ago

fix(aurelia-authentication.js): Changed this.authentication.updateAuthenticated() to this.updateAuthenticated()

The method this.authentication.updateAuthenticated() is not found. Changed it to this.updateAuthenticated() which is the correct method

fixes #370

RWOverdijk commented 6 years ago

@vincentw56 This is good 👌

Could you update the commit message though? That helps with generating the CHANGELOG. https://github.com/SpoonX/about/blob/master/CONTRIBUTING.md#commit

vincentw56 commented 6 years ago

I made the change. Let me know if it still doesn't look right.

RWOverdijk commented 6 years ago

The change doesn't seem to have been pushed. I'm sorry for the really late reply, also.

vincentw56 commented 6 years ago

Not sure I understand what you mean. The change is there, I can see it in the file. What more do you need from me?

RWOverdijk commented 6 years ago

I'll perform the change later.

RWOverdijk commented 6 years ago

https://github.com/SpoonX/aurelia-authentication/pull/380