search

SpoonX / aurelia-authentication

Authentication plugin for aurelia.
http://aurelia-authentication.spoonx.org
MIT License
90 stars 60 forks source link

fix(auth0): fix access and id token assignments #398

Closed jawa-the-hutt closed 6 years ago

jawa-the-hutt commented 6 years ago

Current Auth0 plugin assigns the Auth0 id_token to the access_token object. This fixes that and now you get the Auth0 access_token & id_token correctly assigned.

This is a breaking change, see issue #397

doktordirk commented 6 years ago

oh, i forgot to ask: anything to change here https://github.com/SpoonX/aurelia-authentication/blob/master/doc/api_authService.md

jawa-the-hutt commented 6 years ago

I don't think so, but this reminded me that I should probably update https://github.com/SpoonX/aurelia-authentication/blob/master/doc/auth0.md with the information on the ramifications of the change. I'll try and get that done in the next couple of days.

Would that be a new PR at this point?

doktordirk commented 6 years ago

nah, let's keep it together. just append here

jawa-the-hutt commented 6 years ago

Ok, Auth0 README has been updated with new info.

doktordirk commented 6 years ago

Nice!!! You should make writing docs your profession! The next user will appreciate your effort. Will try it out this weekend (hopefully)

RWOverdijk commented 6 years ago

@jawa-the-hutt Awesome :)