search

SpoonX / aurelia-charts

Graphs plugin for aurelia. Supports all libraries.
MIT License
12 stars 5 forks source link

Npm scripts and install updates #10

Closed doktordirk closed 7 years ago

doktordirk commented 8 years ago

@bas080 i have a test failing.

Config get the charts that match the scale fingerprint FAILED
        Expected [  ] to equal [ Function ].
            at Object.eval (test/unit/config.spec.js:80:78)

is that supposed to work?

doktordirk commented 7 years ago

@bas080 what about the test: there seem to be an error in the code or the test. so, should be either

in the test: config.chartsByScale(quan, quan) and not config.chartsByScale([quan, quan]) or in the code: chartsByScale(...scale) and not chartsByScale(scale)

bas080 commented 7 years ago

@doktordirk, these tests should be passing. That does indeed solve the issue. In my opinion the test is wrong. I prefer the n-arguments approach.