SpoonX / sails-hook-wetland

A sails hook that enables the use of wetland ORM.
MIT License
9 stars 4 forks source link

Add linting #25

Closed edouardmenayde closed 2 years ago

edouardmenayde commented 6 years ago

Hello :-)

I think we all agree we should lint all of our node projects. This this is a first step in this direction. There are still some gotchas to fix : we depend on spoonx-tools which depends itself on aurelia-tools which requires eslint-babel...

@RWOverdijk I added a travis ci file thus it would be cool if you could enable travis for this project :)

RWOverdijk commented 6 years ago

I do agree. Completely. I see some functional stuff changed, so I'll have to review this thoroughly. Have you tested it?

edouardmenayde commented 6 years ago

No I was hoping to do that after having heard back from you about the few challenges using the current eslint configuration poses : mainly the current one is based on aurelia one thus makes use use eslint-babel as a dependency. One way might be to change spoonx-tools repository scope and add a .eslintrc.node.json configuration ? Also that would be cool if you could enable travis just to see if it works. My hope is to create a standard .travis.eslint.node.yml along a bit of doc so that we can easily use eslint + travis in all of our current and future projects.

RWOverdijk commented 6 years ago

Enabled. Push to trigger? :)

RWOverdijk commented 6 years ago

I think you can use the gulpfile from spoonx-tools for linting.

RWOverdijk commented 6 years ago

Looking goooooood

RWOverdijk commented 6 years ago

All that's left is testing then I suppose. I'll give it a go when I work on the server again!