Closed ivelin closed 2 years ago
netlify[bot]
commented
2 years ago | Name | Link |
|---|---|
| Latest commit | fc6549c16cdd7d190130632c84608f8022734a3e |
| Latest deploy log | https://app.netlify.com/sites/sporosdaoapp-dev/deploys/637ebd54212ec80008275236 |
ivelin
commented
2 years ago Quick update. There is a setback due to issues with subgraph. It does not seem to update for a while , which affects poorly UX. Just noticed Kali switched to direct RPC for proposals recently. It's a bummer because subgraph was a big middleware convenience. Not having it requires rewriting front end code to query directly RPC, which takes longer time to write code, test and doesn't scale for many users. In summary, it will take a few more days to rewrite the proposal data access code.
ivelin
commented
2 years ago netlify[bot]
commented
2 years ago netlify[bot]
commented
2 years ago Buttons are not in line.
lipmaneth
commented
2 years ago lipmaneth
commented
2 years ago lipmaneth
commented
2 years ago Clicking on some of the proposals seems to crash the app. For example, proposal 121. It looks like this happens with the proposals where the "Details" button is greyed out. If the "Details" button is green, then it does not crash the app.
lipmaneth
commented
2 years ago lipmaneth
commented
2 years ago Can't click 'details' button for non-PM proposals.
lipmaneth
commented
2 years ago How should we handle notifications such as these where very old proposals (in this case from June) haven't been processed? Perhaps at least let the user delete this notification so it doesn't continuously show up?
ivelin
commented
2 years ago Clicking on some of the proposals seems to crash the app. For example, proposal 121. It looks like this happens with the proposals where the "Details" button is greyed out. If the "Details" button is green, then it does not crash the app.
Browser metadata Open Deploy Preview · Mark as Resolved
Good catch. Fixed.
briareus-the-titan
commented
2 years ago If you connect your wallet and are on a different network than Arbitrum, you need to manually refresh
ivelin
commented
2 years ago If you connect your wallet and are on a different network than Arbitrum, you need to manually refresh
Good catch. Sounds like a wallet callback handling that applies across the app. Should we open this as a separate bug report and handle outside this PR to reduce bloat.
ivelin
commented
2 years ago OK, for the time being, there will be no Details button shown at all for proposals other than PM. See screenshot.
Each proposal type requires thoughtful UX to represent the underlying intention to users in a meaningful way.
Since this PR is already quite bloated as is with 31 file changes, we will be adding UX flows for other proposal types in separate PRs. Next on the TODO list are MINT, ESCAPE, QUORUM, MAJORITY, VOTING_PERIOD. If you prefer, these can be tracked as separate Feature Requests on the product board. @EdgeCaser what would you recommend?
ivelin
commented
2 years ago
Browser metadata Open Deploy Preview · Mark as Resolved
Good catch. Fixed for Projects and Proposals.
ivelin
commented
2 years ago
How should we handle notifications such as these where very old proposals (in this case from June) haven't been processed? Perhaps at least let the user delete this notification so it doesn't continuously show up?
Browser metadata Open Deploy Preview · Mark as Resolved
Interesting issue. Needs some thought. Working on it.
ivelin
commented
2 years ago
How should we handle notifications such as these where very old proposals (in this case from June) haven't been processed? Perhaps at least let the user delete this notification so it doesn't continuously show up? Browser metadata Open Deploy Preview · Mark as Resolved
Interesting issue. Needs some thought. Working on it.
Found the root cause of this issue. Will need some support from Kali. Looks like a subgraph bug: https://discord.com/channels/923399898769018921/925091695677309059/1042502724790522006
https://arbiscan.io/address/0x28fea
c06dc72188b385478b507f7c7a39a7026d5#readContract
ivelin
commented
2 years ago
Interesting issue. Needs some thought. Working on it.
Found the root cause of this issue. Will need some support from Kali. Looks like a subgraph bug: https://discord.com/channels/923399898769018921/925091695677309059/1042502724790522006
https://arbiscan.io/address/0x28fea
Path to solution confirmed with @nerderlyne . Starting work on PR: https://github.com/kalidao/kali-subgraph/pull/18
lipmaneth
commented
2 years ago As a user, there isn't an easy way to get to the previous screen. The 'back arrow' button hides the side bar, but does not take me to the previous screen. To get to a previous screen, I need to hit 'back' in my browser tab.
lipmaneth
commented
2 years ago Clicking on the project details buttons from the proposals main page takes me to a new screen with an error message saying the proposal format isn't supported and I need to visit Kali. That doesn't seem right. We should be able to show details on that screen?
lipmaneth
commented
2 years ago The 'info' icon is a bit confusing. I was expecting to hover over it and be shown a tool tip or some more info. Could just be me though.
lipmaneth
commented
2 years ago The 'Active' buttons are displayed and behave like they should be clickable (e.g. they're shown similarly to the Tribute button which is clickable), however they are not. Should we display them differently in the UI so users don't think they should be able to click them?
lipmaneth
commented
2 years ago It's my understanding that implementing voting for PM proposals is inside the scope of this PR. If so, is there a need to give users the option to visit Kali for PM proposals? What info/actions could they get at Kali that they couldn't get inside our app?
lipmaneth
commented
2 years ago The font size and formatting of the cards for the projects page and proposals page is different.
lipmaneth
commented
2 years ago Clicking the details button sends me to a screen saying more info can't be given. If that's true, then we should at least provide a link to Kali's app from that 2nd page.
lipmaneth
commented
2 years ago Clicking the Kali button sends a user to the main proposal screen inside the Kali app. I'm unclear if there's really a reason to send users to Kali, but if so, a better experience would be to send them directly to the relevant proposal. For example, if I click 'Kali' on the Proposal #114 of the sporos app, then it would take me to the #114 in the Kali app, not the top level proposal page in the kali app.
ivelin
commented
2 years ago Incorrect error "Proposal type not Supported" when proposal is a PM extension.
ivelin
commented
2 years ago UPDATE: Fixed here: https://github.com/SporosDAO/sweat-token/pull/181
Incorrect error "Proposal type not Supported" when proposal is a PM extension.
Browser metadata Open Deploy Preview · Mark as Resolved
ivelin
commented
2 years ago Kali Subgraph and Sporos frontened fixes for this issue are now patched. PRs pending peer review: https://github.com/SporosDAO/sweat-token/pull/182
cc: @lipmaneth
Interesting issue. Needs some thought. Working on it.
Found the root cause of this issue. Will need some support from Kali. Looks like a subgraph bug: https://discord.com/channels/923399898769018921/925091695677309059/1042502724790522006
https://arbiscan.io/address/0x28fea
ivelin
commented
1 year ago
The font size and formatting of the cards for the projects page and proposals page is different.
Browser metadata Open Deploy Preview · Mark as Resolved
Right. In the case of projects the Title is just the Project title. In the case of proposal, there is no title field. Only description. So we do a bit of a hack by merging PM title and settings into proposal description field, which becomes more verbose. Hence the smaller font to display. Since we know which proposals are of type PM, we can display just the PM title instead of the Kali proposal description field. Would that be a better UX?
ivelin
commented
1 year ago Valid point. The thinking was to allow users to have a fallback front end. We can hide the Kali button for PM cards or replace with Etherscan/Arbiscan or leave as is. Let's branch this comment as a separate Good First Issue and agree on desired UX. It's a small self contained fix.
Clicking the Kali button sends a user to the main proposal screen inside the Kali app. I'm unclear if there's really a reason to send users to Kali, but if so, a better experience would be to send them directly to the relevant proposal. For example, if I click 'Kali' on the Proposal #114 of the sporos app, then it would take me to the #114 in the Kali app, not the top level proposal page in the kali app.
Browser metadata Open Deploy Preview · Mark as Resolved
ivelin
commented
1 year ago Interesting. This is a default MUI component decoration for informative alerts. Let's branch this as a separate Good First Issue and agree on desired UX. It's a small self contained fix.
The 'info' icon is a bit confusing. I was expecting to hover over it and be shown a tool tip or some more info. Could just be me though.
Browser metadata Open Deploy Preview · Mark as Resolved
Signed-off-by: ivelin ivelin.eth@gmail.com