Open wjhrdy opened 1 year ago
Unfortunately, this is expected behavior at the moment. The xManager podcast patch is mine but it's not ideal for SpotX and we're trying to find another way to go about it. Once we get it sorted it'll be added to all SpotX repos.
Do you have a link to the source code for the SpotX solution? I was having a hard time finding it in their open repos.
@wjhrdy This organization contains all the source for SpotX and its all open.
@jetfir3 do you have a link to the source for your ad blocking solution? I meant to ask about xmanager.
@jetfir3 do you have a link to the source for your ad blocking solution? I meant to ask about xmanager.
While xManager source is available in the official repo, the mods to the client itself is not opensource.
Feel free to check out the SpotX Community telegram group for pre-built SpotX clients -- the available client for macOS has additional modifications which should help with blocking ads in podcasts.
When we have an official patch to be used across all SpotX repos it will be added to the SpotX source.
Are those prebuilt release podcast ad-blocking changes in a feature branch somewhere?
I reran
bash <(curl -sSL https://raw.githubusercontent.com/SpotX-CLI/SpotX-Mac/main/install.sh) -ceu -E leftsidebar
and I still get podcast ads.
Are those prebuilt release podcast ad-blocking changes in a feature branch somewhere?
no
I reran
bash <(curl -sSL https://raw.githubusercontent.com/SpotX-CLI/SpotX-Mac/main/install.sh) -ceu -E leftsidebar
and I still get podcast ads.
this is with the prebuilt from tg? there shouldn't be any need to run spotx as it's already applied to the build. If ads are still not blocked for you on the pre-built version then nothing can be done at this time.
I upgraded spoify using homebrew here are the repeatable commands i ran assuming homebrew is installed.
curl https://raw.githubusercontent.com/Homebrew/homebrew-cask/381c716e986f059fa81067ce799e8bf985c47064/Casks/spotify.rb > $(find $(brew --repository) -name spotify.rb) && brew reinstall spotify
then run spotify once
bash <(curl -sSL https://raw.githubusercontent.com/SpotX-CLI/SpotX-Mac/cb27772e094028c625a549c7d1049da38a93cae1/install.sh) -ep
These commands result in a version of spotify that still has the reported issue of podcast ads still playing.
This seems to conflict with your comment on telegram
Podcast ads are blocked on the prebuilt version however.
This seems to conflict with your comment on telegram
@wjhrdy The msg in tg suggests that if you don't want to use the pre-built -- to use SpotX-Mac as normal. And in that case, you would not get any additional benefits of the pre-built.
I made the assumption that those updates to the prebuilt binary were reflected in the opensource patch install.sh
as well. Thanks for the clarification. I guess this can stay open since this is not fixed in the github repo.
Updated readme
to note that podcast audio/video ads are currently not blocked by SpotX. As this is expected behavior, I will close this for now.
The team is aware that SpotX alone does not block podcast ads and will continue working to find a clean implementation to remove them. Until then, macOS users who wish to block podcast ads can look into using our prebuilt installers found in the SpotX Community group on Telegram.
@jetfir3 Let keep it open. Its better to have an open issue for it rather than having it just in the readme.
Since this is an issue with all the Spotx-CLI scripts, lets move it to common's
🧐 Have you fully read the README and viewed similar issues?
Сountry of your account
USA
What is your Spotify Plan?
Premium
Do you have Spicetify installed?
No
ℹ Computer information
📝 Description
Looks like xmanager has figured it out on the android side as of very recently. https://xmanagerapp.com/changelog
🖵 Terminal Output
SpotX-Mac by @SpotX-CLI
Spotify version: 1.1.98.691 SpotX-Mac version: 1.1.98.691-1
Backup xpui found, restoring original... Extracting xpui... Applying SpotX patches... Premium subscription setup selected... Adding experimental features... Removing logging... Enabling new home screen UI... Clearing app cache... Blocking updates... Rebuilding xpui... SpotX finished patching!
📸 Screenshots