SpotX-Official / SpotX-Bash

SpotX Mac and Linux adblocker for the Spotify desktop client, in Bash
MIT License
1.7k stars 58 forks source link

Ampersand in a string is causing experimental features to not be installed properly #46

Closed CrystalFyre closed 1 month ago

CrystalFyre commented 1 month ago

🧐 Have you fully read the README and viewed similar issues?

Сountry of your account

Canada

What is your Spotify Plan?

Premium

Do you have Spicetify installed?

No

ℹ Computer information

- Spotify version: 1.2.8.923
- OS: Linux Mint 21.3 Cinnamon
- Shell: bash

📝 Description

  1. Ran the installer, run.sh, which in turn ran the spotx.sh bash file (With or without options or arguments)
  2. ???
  3. And you're done! ...

There's an unintended ampersand & in the middle of a string used for the experimental features Array, expEx. Specifically, on line 865. Change it to the word 'and', and the script will run fine.

🖥️ Terminal Input/Output

Searching for Spotify directory...

Found Spotify Directory: /usr/share/spotify

cat: /etc/upstream-release: Is a directory
Debug: Linux Mint 21.3
Debug: x86_64 detected
Debug: APT detected
Debug: flatpak detected
Debug: Cache directory: ~/.cache/spotify

Latest supported version: 1.2.39.578
Detected Spotify version: 1.2.8.923

✔ Created backup
✔ Applied free-tier plan patches
Unquoted string "web" may clash with future reserved word at -e line 1.
String found where operator expected at -e line 1, near "web",default:\K!1}"
Unknown regexp modifier "/t" at -e line 1, near "+= "
Can't find string terminator '"' anywhere before EOF at -e line 1.
✔ Enabled experimental features
✔ Enabled new UI
✔ Finished

📸 Screenshots

image

jetfir3 commented 1 month ago

Sorry about that. Good catch. Fixed.