search

Spotifyd / spotifyd

A spotify daemon
https://spotifyd.rs
GNU General Public License v3.0
9.91k stars 452 forks source link

Add support for `rodiojack` backend. #1281

Closed agdphd closed 4 months ago

agdphd commented 7 months ago

The underlying librespot library already supports the JACK audio backend via rodio. Enabling it in spotifyd turns out to be dead simple--just needed to add the config enum elements to pass it through!

NOTE: I have tested this on my machine running Debian testing ("trixie"). The documentation for Fedora is based on the upstream docs for librespot: https://github.com/librespot-org/librespot/blob/329a1b16074af4d1a8abe2ed017b5d4a4a070ea1/COMPILING.md#audio-library-dependencies

eladyn commented 6 months ago

And I fixed the clippy lints in #1282, so if could rebase your changes, that would be nice as well

agdphd commented 6 months ago

Thanks for your review! Removed the spurious jackaudio references and rebased to current HEAD.