Sprayxe / valorant.js

An API Wrapper for valorant with oauth support
MIT License
18 stars 6 forks source link

The API endpoint /content-service/v2/content are using v3 instead of v2 now #19

Open survfate opened 2 years ago

survfate commented 2 years ago

https://github.com/Sprayxe/valorant.js/blob/f112083e223888107b1ac85c28e65c9394bae95b/src/services/ContentApi.ts#L52

With v2 it'll return 404, I'm not sure if v3 having the same amount of data compare to v2 but at least it is working

image

FPilica commented 2 years ago

It does have less, but there is also the possibility of using Henrik's API which has the same response as v2. Will leave it to @Sprayxe to decide

survfate commented 2 years ago

It does have less, but there is also the possibility of using Henrik's API which has the same response as v2. Will leave it to @Sprayxe to decide

oh I didn't know an alternative exist, will try using that for a friend server for now

survfate commented 2 years ago

@Speeedyyyy are you still using this lib by any chance? I used Henrik's API for content endpoint now but the getStorefront function seem to also stopped working (I know its not related to this thread but still...)

image

FPilica commented 2 years ago

It is possible something changed, either way I can only commit to GitHub, but can't push it to npm. I'm gonna forward this to Sprayxe and he will probably respond to this thread.

Sprayxe commented 2 years ago

I will look into your issues asap. (I haven't worked on this library as it requires a small refactor but I haven't had the motivation to work on a js project haha)

Sprayxe commented 2 years ago

It's gonna take a bit longer as I am restructuring the whole library and adding some more endpoints, sorry for that!

survfate commented 2 years ago

@Sprayxe no worries, with my limited nodejs experience I'm just trying to put something together for temporary usage for now

survfate commented 2 years ago

update for who check at this thread looking for a band-aid fix, I used https://api.henrikdev.xyz/valorant/v1/content as an alternative and update ItemParser.ts accordingly (since the json response is a tad bit different) and its good for running locally again (check my fork)

mgsteam commented 2 years ago

@Sprayxe @Speeedyyyy Any updates?