Open buybackoff opened 5 years ago
Important to remember that LMDB data is practically not aligned (to 2-bytes in dupsorted from 2014 comments from googling). Issue is here to review later that now data is returned without https://docs.microsoft.com/en-us/dotnet/api/system.reflection.emit.opcodes.unaligned?view=netframework-4.7.2
We must use (review usage if already) Unsafe.ReadUnaligned for any pointer read to T.
Unsafe.ReadUnaligned
T
For Intel x64 it's ~noop and for others it's correctness issue, so performance doesn't matter.
Important to remember that LMDB data is practically not aligned (to 2-bytes in dupsorted from 2014 comments from googling). Issue is here to review later that now data is returned without https://docs.microsoft.com/en-us/dotnet/api/system.reflection.emit.opcodes.unaligned?view=netframework-4.7.2
We must use (review usage if already)
Unsafe.ReadUnalignedfor any pointer read toT.For Intel x64 it's ~noop and for others it's correctness issue, so performance doesn't matter.