Spreads / Spreads.LMDB

Low-level zero-overhead and the fastest LMDB .NET wrapper with some additional native methods useful for Spreads
http://docs.dataspreads.io/spreads/libs/lmdb/api/README.html
Mozilla Public License 2.0
80 stars 9 forks source link

Allow config to be set when Bootstrapper is not available. #34

Closed vinaychandra closed 5 years ago

vinaychandra commented 5 years ago

If for any reason, Bootstrapper class is not able to be initialized (see this), Config can never be initialized. Please allow the DefaultLocation to be settable when the Bootstrapper class is unavailable.

buybackoff commented 5 years ago

Please see #33 and #28. Bootstrapper is no longer used and native binaries are packed with NuGet.

vinaychandra commented 5 years ago

Bootstrapper is currently being used in this line which causes this issue.

https://github.com/Spreads/Spreads.LMDB/blob/002e9b0d4a5e632c6e2a8330b36e4b19d8b01639/src/Spreads.LMDB/Config.cs#L36

buybackoff commented 5 years ago

Ah! Need to replace Bootstrapper here with some config. Or better remove that default completely and always require path for each LMDB environment. I'm not sure if DefaultLocation is actually used anywhere.

buybackoff commented 5 years ago

@vinaychandra NuGet is updated