search

Spreadsheets / WickedGrid

Easy & Wicked Fast spreadsheets for the web
http://spreadsheets.github.io/WickedGrid
587 stars 131 forks source link

Bower pros & cons #31

Closed demonslord closed 10 years ago

demonslord commented 10 years ago

Hi, On my opinion, using the bower is good for repository size, but is not good for plugin, because you need always be "on alert" because the 3rd party plugins can be changed, and you need refactor your code.

At this moment, you need refactor this line:

jS.undo.manager.register(u, jS.undo.removeCells, [before, id], 'Remove Cells', u, jS.undo.createCells, [after, null, id], 'Create Cells');

Because the Javascript-Undo-Manager plugin was changed recently by author.

Best Regards.

demonslord commented 10 years ago

Well,I checked the plugin Javascript-Undo-Manager, and the author has dropped support of arguments.

:(

robertleeplummerjr commented 10 years ago

Well, that is no good.

robertleeplummerjr commented 10 years ago

Suggestions? On Aug 8, 2014 10:10 AM, "Alexander Bulei" notifications@github.com wrote:

Well,I checked the plugin Javascript-Undo-Manager, and the author has dropped support of arguments.

:(

— Reply to this email directly or view it on GitHub https://github.com/Spreadsheets/jQuery.sheet/issues/31#issuecomment-51606852 .

demonslord commented 10 years ago

Hi @robertleeplummerjr , Well, I see only one solution, use the old method, do commit of 3rd plugins to repository.

Best Regards.

robertleeplummerjr commented 10 years ago

I ended up contact the developer and getting this bug worked out by upstreaming the existing code.