SpreeTravel / odoo-saas-tools

Odoo (OpenERP) addons to provide SaaS
5 stars 4 forks source link

First Cenit as OAuth2 provider module prototype #7

Closed dhbahr closed 8 years ago

dhbahr commented 9 years ago

This includes the first module prototype for using Ruby on Rails + Doorkeeper as OAuth2 providers, with a default data set for CenitHub as well as the addition of a couple of fields to the auth_oauth_provider model needed.

yelizariev commented 9 years ago

Your description is a little bit mislead. There are no only odoo oauth2 provider in odoo system. There are built-in templates for google, facebook oauth providers.

Could you explain why Cenit cannot work without source modification?

Also, even this module is helpful, I don't think it should be in saas repository. Your module is just some tool for any odoo database. Do you agree with me?

dhbahr commented 9 years ago

Regarding the description: Yes, you are quite right about , my bad, I've edited the first sentence.

The problem for Cenit's RoR+Doorkeeper is that the Authorization flow is different than the standard specification (https://tools.ietf.org/html/rfc6749#section-4) in that for doorkeeper the 'Validation Request' is made via POST, not GET, and a 'client_secret' value is required and the responses don't contain the values auth_oauth expects, resulting in the impossibility to use Cenit (www.cenitsaas.com) as the OAuth Provider The module also provides support for "Resource Owner Password Credentials Grant" (https://tools.ietf.org/html/rfc6749#section-4.3).

You have a very good point regarding whether this should go into the odoo-saas-tools repository, as it is very Cenit-OAuth-specific. I'll probably be moving it soon.

Best regards