Closed GoogleCodeExporter closed 9 years ago
Salut Nicolas,
Many thanks for your contribution.
I applyied your patches to the current codebase (no committed yet).
I see two issues:
- a new dependency against emf.common.ui is introduced by the use of
ResourceDialog.
Is it really mandatory?
- you have a statement
if (multiPageEditor instanceof MultiPageEditor) {
in MultiPageEditorContributor.
Eclipse detects that that condition is always satisfied since multiPageEditor is
declared as a MultiPageEditor.
I guess I can safely remove that code?
--Daniel
Original comment by daniel.l...@gmail.com
on 26 Jun 2007 at 7:13
Hi Daniel,
The dependency on emf.common.ui is indeed mandatory to make sure the
ResourceDialog
class is available to the plugin's classloader.
The test is similar to a more familiar test: if (multiPageEditor != null) ....
In either form, the test guards against NPE in: viz =
multiPageEditor.getVizGUI()
NPE could otherwise happen if MultiPageEditor.setMultiPageEditor(...) hasn't
been
called yet.
Cheers,
-- Nicolas.
Original comment by tinov...@gmail.com
on 26 Jun 2007 at 5:36
Hi Nicolas,
Isn't there a class similar to a ResourceDialog in the basic jface framework?
I would like to avoid if possible to add a new dependency to the plugin.
Regarding 2, I would prefer to change it to a traditional if (multiPageEditor !=
null): the intent of that line of code would be clearer that way.
BTW, I see that you have a google account. Would you like to join to project?
--Daniel
Original comment by le.ber...@free.fr
on 26 Jun 2007 at 6:44
Hi Daniel,
I'm not a "jface" expert, ResourceDialog was the simplest specialization of a
Dialog
I found providing the desired functionality.
Unless the functionality is available in jface, it may be sensible to suggest
migrating the emf.common.ui ResourceDialog functionality elsewhere in jface to
the
EMF/JFace folks.
Yes, joining the project would be simpler for me. Note however that for any
kind of
significant contribution, I have to go through a review project with JPL and
Caltech
that usually takes 1~2 weeks.
Original comment by nicolas....@gmail.com
on 26 Jun 2007 at 7:03
Welcome on board Nicolas!
Please feel free to commit your patch on SVN by yourself.
We will live with the emf dependency for now.
--Daniel
Original comment by daniel.l...@gmail.com
on 26 Jun 2007 at 9:16
Original comment by daniel.l...@gmail.com
on 26 Jun 2007 at 9:17
Daniel, there's been a mistake.
Please change my login to "nicolas.rouquette@jpl.nasa.gov", not "tinovska".
-- Nicolas.
Original comment by nicolas....@gmail.com
on 26 Jun 2007 at 10:15
Nicolas,
Are you "tinovska" or not? I can only register people having a gmail account.
If you do not have one yet, you will need one to join the project.
--Daniel
Original comment by daniel.l...@gmail.com
on 27 Jun 2007 at 5:25
Nicolas,
I just added your patch to SVN.
--Daniel
Original comment by daniel.l...@gmail.com
on 27 Jun 2007 at 8:01
A new release (0.1.5) containing your contribution and updated to Alloy 4 RC10
is
available on the update site.
Original comment by daniel.l...@gmail.com
on 27 Jun 2007 at 8:51
Nicolas,
I just committed to SVN a modified version using SWT FileDialog instead of your
ResourceSelectionDialog.
Could you check that everything works fine? (I do not use thm files myself).
--Daniel
Original comment by daniel.l...@gmail.com
on 27 Jun 2007 at 8:09
Hi Daniel,
My google ID is: "nicolas.rouquette@jpl.nasa.gov"
With the attached patches on top of your changes, A4E works reasonably well
(IBM RSA
7.0.0.2 / Eclipse 3.2.1) including the application of A4 visualization themes.
-- Nicolas.
Original comment by nicolas....@gmail.com
on 28 Jun 2007 at 12:14
Attachments:
Hi Nicolas,
many thanks for your help.
I committed your changes to SVN and released version 0.1.6 of the plugin.
You need a gmail account to participate to a google code project.
Your Google ID does not work with google code.
Sorry.
--Daniel
Original comment by daniel.l...@gmail.com
on 28 Jun 2007 at 7:17
Original issue reported on code.google.com by
nicolas....@gmail.com
on 25 Jun 2007 at 11:21Attachments: