SpringOne2GX-2014 / reactive-geocoder

Reactive Geocoding Demo
Apache License 2.0
35 stars 14 forks source link

- Updated and organized the imports; #2

Open tiarebalbi opened 9 years ago

tiarebalbi commented 9 years ago
thiagogcm commented 9 years ago

Hey Tiarê, I was working in the same changes last night. I did a few different things that you did though

My locationEventStream method is as follow:

@Bean
    public Broadcaster<Location> locationEventStream(Environment env) {
        return Streams.broadcast(env.get());

    }

on findOne and update methods I used Environment.get() instead of Environment.cachedDispatcher()

and I also changed the ratpack version to 0.9.11

tiarebalbi commented 9 years ago

@thiagogcm i agree with your observation, the only thing that i'll be checking is about the bean definition, as you can see by the picture bellow i don't have access to the method broadcast() on the class Streams.

i sent a parcial change with your comments.

screen

tiarebalbi commented 9 years ago

I was checking here and the method broadcast() is not static. https://github.com/reactor/reactor/blob/master/reactor-core/src/main/java/reactor/rx/Stream.java#L306-L308

I'm not sure that this usage "Broadcaster.create()" is the better way to define this bean, i'm open for more opinion.

thiagogcm commented 9 years ago

That's weird.. I checked the API and it's static I'm working with M2 build since I couldn't find the RC1 API selection_006