SpriteLink / NIPAP

Neat IP Address Planner - NIPAP is the best open source IPAM in the known universe, challenging classical IP address management (IPAM) systems in many areas.
https://spritelink.github.io/NIPAP/
MIT License
524 stars 132 forks source link

Handle binary data from LDAP #1347

Closed garberg closed 8 months ago

garberg commented 8 months ago

It seems the Python 3 version of the LDAP module returns bytes instead of strings. This caused the full name fetched from LDAP, now a bytes object, to be passed around and sent to the backend as an xmlrpc.client.Binary from the web UI and causing a crash.

Updated the LdapAuth class to decode the received full name and encode strings to bytes before determining group membership.

garberg commented 8 months ago

LGTM