search

SpriteOvO / AirPodsDesktop

☄️ AirPods desktop user experience enhancement program, for Windows and Linux (WIP)
GNU General Public License v3.0
1.49k stars 87 forks source link

Installer requires the current user level instead of always admin level #79

Open SpriteOvO opened 1 year ago

SpriteOvO commented 1 year ago

Closes #77.

We use an undocumented option CPACK_NSIS_DEFINES to override the value of RequestExecutionLevel as highest, which causes the generated installer to ask admin privilege for admin users and normal user privilege for standard users.

This undocumented option conflicts with CPACK_COMPONENTS_ALL (https://cmake.org/Bug/view.php?id=14522)

Blocked by https://gitlab.kitware.com/cmake/cmake/-/merge_requests/8767

CPack/NSIS currently has a bug that sets C:\Program Files (x86) as the default installation path for standard users, who does not have write access to this path.

SpriteOvO commented 1 year ago

CC @aetrnm, could you try the new installer after the CI completes compilation and give some feedback?

It currently has a known issue where the default installation path is incorrect and you need to manually change it to a directory that you have permission to write to. This will be fixed when the upstream MR (that Blocked By link) is merged.

SpriteOvO commented 1 year ago

Oh, I'm sorry. I mentioned the wrong person. I should CC @amwihgu.

amwihgu commented 1 year ago

Oh, I'm sorry. I mentioned the wrong person. I should CC @amwihgu.

CC @aetrnm, could you try the new installer after the CI completes compilation and give some feedback?

It currently has a known issue where the default installation path is incorrect and you need to manually change it to a directory that you have permission to write to. This will be fixed when the upstream MR (that Blocked By link) is merged.

Hello, Great news, I tried directly and found it working! Thanks for the update!