search

Spritetm / esppdp

ESP32-based PDP11 simulator, based onSimH
123 stars 21 forks source link

build fails with format errors #2

Open leifj opened 1 year ago

leifj commented 1 year ago

I just tried building the project firmware using a fresh clone of esp-idf but the build fails with format errors ie -Werror=format

leifj commented 1 year ago

One example:

/home/leifj/esppdp/firmware/main/pdp11_rq.c:3286:58: warning: format '%d' expects argument of type 'int', but argument 3 has type 'uint32' {aka 'long unsigned int'} [-Wformat=]

SvenMb commented 1 year ago

Use the older 4.x esp-idf. esp-idf 5.x introduced some extra code checks, which lead to this error.

Best use is esp-idf 4.3, since 4.2 didn't had the 'esp_bt.h' and 4.4 introduced some different usage of the IRAM, so the project don't fit in default config.

Isysxp commented 1 year ago

Dear Sprite_tm,

You have done a stunning job here of stripping Simh down to produce a suitable image for the ESP32. I have looked into this in the past and given up in despair! So I built a much simpler PDP11 emulator. Anyway, the only problem with the repo is as above in that trying to build this with IDF 5.0 generates lots of errors (warnings). I have attached a rather dubious patch to sort this out. In addition, I have also changed some of the options in sdkconfig. I have attached this file as well as the format has changed from IDF 4->5. The final image now runs fine on my Wrover kit. (Google Drive) https://drive.google.com/file/d/192e8-08gp3iPm5B2T6XzKR-vhc4VgO48/view?usp=sharing EspPdp11.patch

Spritetm commented 12 months ago

@Isysxp Thanks for the patch! Unfortunately, it seems to be misformed, I can't get it to apply (patch says 'Only garbage was found in the patch input.' and on casual inspection at least the filenames to patch are missing)

Isysxp commented 12 months ago

Well, this is embarrassing. I used WinMerge to create this patch and apologies as there does not seem to be any way to use patches in this format!!!! So, I have created a fork with the updated code which I hope is OK. I would note that this is not a brilliant solution and there are still many build warnings. However, it is adequate for anyone using the latest IDF install.

Spritetm commented 12 months ago

Sure, if you can tell me where the fork is, I can pull from that, or you can see if you can create a pull request myself.

Isysxp commented 12 months ago

I have created it in https://github.com/Isysxp/esppdp.