Spritetm / hadbadge2019_fpgasoc

FPGA SoC code and application example for Hackaday Supercon 2019 badge
Other
157 stars 70 forks source link

Fix button mappings (a and b were swapped) #126

Closed jordiorlando closed 4 years ago

jordiorlando commented 4 years ago

The button mapping for A and B was incorrect, this swaps/fixes them. According to the schematic, SW5 is BTN_A and SW6 is BTN_B. (All the bugs on this badge not caught in the prototypes are now official features.)

jordiorlando commented 4 years ago

2019-Hackaday-Superconference-Badge-front2

Spritetm commented 4 years ago

That's a good catch, however I'm a bit hesitant to merge this as it will reverse the mapping of everyones buttons... if they're already used to where they need to press, this will mess with their motor memory. Any suggestions to stop that from happening?

jordiorlando commented 4 years ago

I think most people won't be updating their badge from master during supercon, so maybe it won't matter. But I think it's worth having the code match the schematics. All the built-in apps could be changed to use the B button instead of A and vice versa, so at least they would be in the same positions? Was the intention to have A on the bottom left and B on the top right like in the image?

jordiorlando commented 4 years ago

Closing bc who cares :D