search

Spritetm / hadbadge2019_fpgasoc

FPGA SoC code and application example for Hackaday Supercon 2019 badge
Other
159 stars 70 forks source link

Circuit Invaders Game #73

Closed ANDnXOR closed 5 years ago

ANDnXOR commented 5 years ago

Another simple game to demonstrate the badge graphics engine. Avoid resistors, capacitors, and 18650s. Shoot "photons" from your LED to destroy the "aliens".

Spritetm commented 5 years ago

Thanks! There's a fair amount of build artifacts (build directory, .sym file, ....) in the tree at the moment. Can you remove that and add a .gitignore for them?

ANDnXOR commented 5 years ago

Oh derp. Will do

On Fri, Nov 8, 2019, 2:26 AM Jeroen Domburg notifications@github.com wrote:

Thanks! There's a fair amount of build artifacts (build directory, .sym file, ....) in the tree at the moment. Can you remove that and add a .gitignore for them?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Spritetm/hadbadge2019_fpgasoc/pull/73?email_source=notifications&email_token=AEDUEXKK73N2PGO6Y324FKTQSU5FHA5CNFSM4JKTM2RKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDP3VXQ#issuecomment-551533278, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEDUEXPX25LOCOHCU27JPZDQSU5FHANCNFSM4JKTM2RA .

smunaut commented 5 years ago

Is there any benefit to keeping all the history vs just doing a rebase and squash ?

Spritetm commented 5 years ago

That is a discussion that be held and then fall to either sides on a more serious project. I'm a simple guy here: I see a result that I like and that's mergable, I press 'merge pull request'.

ANDnXOR commented 5 years ago

Either way, doesn't matter to me. History is on my github anyways if people are really concerned about this amazing piece of work.

Spritetm commented 5 years ago

Just gave it a test, you may want to work on gameplay a bit more if you want this to be more than an example... I can finish every level up to level 16 by keeping A pressed; I die at level 16 because that is a killscreen as my bullets don't seem to move or come out anymore. (Note that if you don't want to do that, that's fine too, if any it serves as an example.)

daveshah1 commented 5 years ago

That is a discussion that be held and then fall to either sides on a more serious project. I'm a simple guy here: I see a result that I like and that's mergable, I press 'merge pull request'.

They weren't so big here so it doesn't really matter; but where build results have been accidentally added and are then deleted in a subsequent commit they bloat the repository forever - whereas they wouldn't with a squash/rebase.

ANDnXOR commented 5 years ago

I'll work on the gameplay, wanted to get at least an example in since HaD is in a week and I have some personal commitments taking time away the next few days.