Effectively, we're splitting apart the old intakePlayer in player service. This method used to be an upsert: if the MLEID already exists, overwrite its data with the new input, and if it doesn't, create a new player/member/user. This has recently caused a lot of difficulty for support staff when one player's valid data was accidentally overwritten with another's.
New design: intakePlayeronly inserts. If the MLEID input already exists, throw an error. updatePlayer takes slightly different arguments, and only updates. If the MLEID input does not yet exist, throw an error. The hope is that this slight API change will cause enough attention to detail that our FA intake folks don't completely overwrite an existing player in the future.
Next feature up is having MLEIDs auto-generated anyway, so this should be a moot point soon, but why not get the API right right now.
Effectively, we're splitting apart the old
intakePlayerin player service. This method used to be an upsert: if the MLEID already exists, overwrite its data with the new input, and if it doesn't, create a new player/member/user. This has recently caused a lot of difficulty for support staff when one player's valid data was accidentally overwritten with another's.New design:
intakePlayeronly inserts. If the MLEID input already exists, throw an error.updatePlayertakes slightly different arguments, and only updates. If the MLEID input does not yet exist, throw an error. The hope is that this slight API change will cause enough attention to detail that our FA intake folks don't completely overwrite an existing player in the future.Next feature up is having MLEIDs auto-generated anyway, so this should be a moot point soon, but why not get the API right right now.