Spuds / SMF-Member-Awards

Member Awards for SMF 2.0
Other
8 stars 8 forks source link

Group Assign non-functioning #13

Closed dyn0 closed 11 years ago

dyn0 commented 11 years ago

I believe creating an individual issue on Github is the correct approach. I do apologize if this is not standard practice.

Trying to assign a full member group to a certain award. I have 2 awards in 1 category and 12 member groups. The account I'm using is an Administrator account (full rights).

To replicate:

Member Assign: http://www.WEBSITE.com/index.php?action=admin;area=awards;sa=assigngroup

Selected 1 award under the field "Select Award to Assign" Date Received: today - "August 4 2013" Selected 1 member group under the field "Select Membergroups" Press 'Assign'.

Taken to the following page: http://www.WEBSITE.com/index.php?action=admin;area=awards;sa=viewassigned;a_id=1

The above page is the correct 'awards' page. If I select another award, id2 for example, pressing the 'Assign' button does take you the view assigned page for id2.

No errors are displayed in logging.

THANK YOU.

dyn0 commented 11 years ago

Group assign is indeed working.

The only caveat is that one member group is only able to be assigned to one award. For example: I have 2 groups which need to share the Moderator award, "Administrators" & "Global Moderator". It is impossible for both of these member groups to share the Moderator award. When trying to add multiple member groups nothing happens.

Edit: It is possible to add a member via single / member assign and have them share an award with another group.

dyn0 commented 11 years ago

Browser crashed as I was making an edit. Ugh.

Spuds commented 11 years ago

OK .. l'll take a look at that as well

Spuds commented 11 years ago

Another update for this issue ... this should address the issue, which was the db value being passed for the key was not unique ... in an attempt to keep it a unique index on this table instead of using -1 as the member_id of a group award, it now uses -group_id ...

This should fix the issue and I believe I got all the areas that needed to be changed to support this fix.

dyn0 commented 11 years ago

I've tested this and can not cause it to malfunction... seems to be working as intended! Thank you!