SpunkyBot / spunkybot

Multi-platform administration and RCON tool for Urban Terror
https://spunkybot.de
MIT License
20 stars 24 forks source link

Requesting new feature to allow config whitelist of allowed ports #122

Closed ge0rdie closed 3 years ago

ge0rdie commented 3 years ago

Hi AK,

I would like to request a feature that would allow me to implement a setting to configure a whitelist of allowed ports and reject connections on any others.

The bot already rejects connections from 1337, so it would be an extension of that. I would suggest a default setting of "ALL" that can be replaced by a list of specific port numbers.

eg:

allowed_ports = ALL allowed_ports = 27960 27961 27962

thanks --ge0rdie

alexanderkress commented 3 years ago

Hello,

so you mean the following: block every client which is not using one of the defined ports on the whitelist? correct?

The 1337 filter is the opposite, it allows every port except this 1337.

So if the new feature is enabled, only the defined will be able to join. But please keep in mind: in case two sisters sharing the same internet connection, one may have a problem. One will have 2796x, while the other has a random one and will not be able to join.

Actually, I am not even sure, if majority of people will use random ports...

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 3 years ago

This issue was closed because it has been stalled for several days with no activity.