SpunkyBot / spunkybot

Multi-platform administration and RCON tool for Urban Terror
https://spunkybot.de
MIT License
20 stars 24 forks source link

added !sk and randommap #134

Closed ElCopado closed 2 years ago

ElCopado commented 2 years ago

Thank you for contributing a Pull Request!

Please follow the checklist:


What is the purpose of your pull request:

Description:

Please make sure the description explains the purpose and effect of the pull request

Explanation of your pull request in arbitrary form goes here.

If you are fixing an existing issue, please include "Fixed #nn: <Summary>" in
your commit message and your description which explains what the change does.
sourcery-ai[bot] commented 2 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.33%.

Quality metrics Before After Change
Complexity 498.73 ⛔ 519.90 ⛔ 21.17 👎
Method Length 132.66 😞 134.60 😞 1.94 👎
Working memory 100.38 ⛔ 103.68 ⛔ 3.30 👎
Quality 33.18% 😞 32.85% 😞 -0.33% 👎
Other metrics Before After Change
Lines 4028 4090 62
Changed files Quality Before Quality After Quality Change
spunky.py 33.18% 😞 32.85% 😞 -0.33% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
spunky.py LogParser.handle_say 1385 ⛔ 12464 ⛔ 263 ⛔ 0.00% Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
spunky.py LogParser.handle_kill 122 ⛔ 891 ⛔ 27 ⛔ 1.46% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
spunky.py LogParser.handle_awards 51 ⛔ 534 ⛔ 37 ⛔ 3.63% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
spunky.py LogParser.find_game_start 42 ⛔ 361 ⛔ 24 ⛔ 9.14% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
spunky.py LogParser.taskmanager 40 ⛔ 338 ⛔ 19 ⛔ 12.75% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!