Spy-Shifty / BrokenBricksECS

Rebuild of Unity3D upcoming Entity Component System !OUT OF DEVELOPMENT!
MIT License
162 stars 28 forks source link

Entitycomponentsapi #14

Closed acoppes closed 6 years ago

Gwindalmir commented 6 years ago

You know, I made this exact same change locally a few weeks ago (for the same reasons you did). I didn't issue a pull request because I wasn't sure if modifying Entity to contain this would be appropriate for this project.

That said, I would suggest adding [NonSerialized] to the entityManager field. Also, you missed the SetComponent method.

(Note: I have no authority here, these are just friendly suggestions. :smile: )

Spy-Shifty commented 6 years ago

I want me to stay with the Unity implementation for now. So I reject it.