Closed enzi closed 6 years ago
I believe a good way to do a pull request is to first make a branch, make your changes and upload that branch to your fork, then go to pull request, and select that branch, normally you are going to have a small number of commits.
A recommendation is to have always your master branch from your fork updated with the latest one from the main repo, that way the changes to merge are smaller.
Not sure if that helped xD
On Thu, Jan 18, 2018 at 8:31 PM, enzi notifications@github.com wrote:
Hey!
I'm unfamiliar how pull requests works, I made a change here: enzi/BrokenBricksECS@f6b105f https://github.com/enzi/BrokenBricksECS/commit/f6b105f5204bba7259b03d93212796ab052bd311
I hope you can integrate it.
Cheers!
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Spy-Shifty/BrokenBricksECS/issues/25, or mute the thread https://github.com/notifications/unsubscribe-auth/AAkH7AaITv8PumkZHfSN215YWWfnKoevks5tL9Q4gaJpZM4Rjvty .
--
Gemserk Studios http://blog.gemserk.com
Yes that helped! I didn't make a branch, now the pull request has all files in it. But I know now what to do. Thanks!
Thank you! But I didn't received a pull request.
Ok I believe I add this by hand ^^
Added aad16a2a775c4a600a1254e108cf11044ae02ac1
Hey!
I'm unfamiliar how pull requests works, I made a change here: https://github.com/enzi/BrokenBricksECS/commit/f6b105f5204bba7259b03d93212796ab052bd311
I hope you can integrate it.
Cheers!