Spyderisk / domain-network

Network domain model
Apache License 2.0
1 stars 0 forks source link

Bug in data flow inference sequence #108

Closed mike1813 closed 8 months ago

mike1813 commented 9 months ago

Pattern PDOP-S+fS creates a self-referential 'fromSource' link at an Output Pool (a Data Access subclass representing data produced by a process that has no other data source).

This is incorrect - an Output Pool (being a process output) would already be marked as a data source by that point. The pattern should have acted on an Input Pool with no other source.

mike1813 commented 8 months ago

Turns out the problem isn't that Output Pools don't need to be tagged at this point. The problem is that the tag should be added a little earlier, and Input Pools should have the same treatment.

Now fixed in branch 85, although there are still some unresolved corner cases arising from #40.