Spyderisk / domain-network

Network domain model
Apache License 2.0
1 stars 0 forks source link

Construction sequence bug in HuirPeI-OD-p-cC-iHu-DS+c #145

Open mike1813 opened 1 week ago

mike1813 commented 1 week ago

Construction pattern HuirPeI-OD-p-cC-iHu-DS+c adds a 'creates' relationship between a Process and Data where the Process enables user output of that data, but has no 'processing' relationship to the Data, and the Data cannot come from anywhere else.

The subsequent pattern HuirPeO-ID-p+r adds a 'receives' relationship if there is still has no 'processing' relationship between the Process and Data. This should be done after HuirPeI-OD-p-cC-iHu-DS+c.

Unfortunately, there is a typo in the priority for HuirPeI-OD-p-cC-iHu-DS+c, whereby it has the same priority as HuirPeO-ID-p+r. If two patterns have the same priority, system-modeller executes one pattern at a time but in an arbitrary order, so it is possible these patterns may be run in reverse order, so a 'receives' will be inferred even if there can be no other source of the data but creation by the Process.

This should be fixed.

Note that issue #140 also calls for changes in HuirPeI-OD-p-cC-iHu-DS+c, so could be done at the same time as that.