search

Spyderisk / domain-network

Network domain model
Apache License 2.0
1 stars 0 forks source link

Bug in OAuth-style authentication model #62

Closed mike1813 closed 1 year ago

mike1813 commented 1 year ago

If a Client uses a Service, and an Authenticator controls the Service, a construction pattern adds a Client-usesForAuth-Authenticator link if none is present. This represents the Client-Authenticator relationship created when the Service redirects to the Authenticator.

In principle, it is possible for the Authenticator to be controlled by another Authenticator. In that case, one should get a second redirection from the first Authenticator to the second. However, the construction pattern does not detect this.

Looks like there is a typo - the pattern is iterative, so there is a prohibited Client-usesForAuth-Authenticator to ensure the pattern doesn't repeat indefinitely. However, the prohibited link is specified as Client-usesForAuth-Service, which obviously blocks recursive application.

mike1813 commented 1 year ago

Now fixed in branch 47.

mike1813 commented 1 year ago

Found another bug in pattern CScP-v+AA. Now fixed on branch 47.