Open mike1813 opened 11 months ago
As a first step, we can fix the overload threats affecting the test case created for issue #95, and other such threats:
In addition:
The following have been checked and should not depend on the Host being In Service:
I.O.HIoH.3.1 not deleted, as the threat description suggests it may be intended to cover certain non-IP subnets that would not be covered by I.O.LoH.3. It may still need to be deleted, but this should first be checked more carefully. Instead, this threat was made dependent on the target Interface being in service.
These changes have been made on branch #95, since that will involve changes to some overload/availability threats.
Suggest future steps towards addressing this issue should also be incorporated into fixes for other issues, as and when relevant.
Normal operations that have the potential to increase risks are modelled as threats. For example, a Host becomes more exposed to other threats when switched on, so turning on a Host is represented as a threat leading to the behaviour 'In Service'. This or the associated TWA is then used as a cause in other threats that would not apply to the Host were it still switched off. To prevent those other threats, one can use a (temporary) disablement control strategy to block the threat cause representing the Host being switched on.
It would be helpful if some of these normal operation threats were 'no cause' threats, as described in #95. A test case created for that has revealed that some threats don't depend on the In Service behaviour when they should. Enabling the disabledment CSG doesn't block all threat paths.
For example, I.O.IoH.3 represents a DoS attack from the Internet on a host interface leading to overload and indirectly loss of availability in communications with the host. This does not depend on the Interface being 'In Service', presumably (but if so, wrongly) because if the Interface (or equivalently, its Host) were disabled it would not prevent the resulting loss of availability.
This presumption is incorrect on two grounds. Firstly, the DoS attack leads to overload, not directly to loss of availability. Clearly, if either the Host or the targeted Interface was disabled, it could not be overloaded. Secondly, the loss of availability due to an overload does not matter if the Host was unavailable due to the side effects of a disablement control strategy. The threat path leading to loss of availability due to the DoS attack is nonsensical - the fact that it happens for other reasons doesn't make this reason valid.
The test case before host disablement is Issue 95 Test - No Controls - Asserted.nq.gz.
The same test case after host disablement is Issue 95 Test - Disabled Host - Asserted.nq.gz.
The same issue may be present in assets other than Hosts.
All threats should be reviewed to determine whether they should depend on any involved asset being In Service, and this should be added as a cause where it has been wrongly omitted. This will take some time, so this issue should be kept open, but changes merged into the main development branch (currently '6a') as and when they can be implemented.