search

Spyderisk / system-modeller-adaptor

Service sitting in front of the system-modeller, providing additional (sometimes experimental) functionality
Other
0 stars 0 forks source link

7 renaming Cyberkit4SME groups and paths to state_report_management #11

Open panositi opened 1 month ago

panositi commented 1 month ago

References and path names renamed from Cyberkit4SME to State Report Management now.

panositi commented 1 month ago

Both SSM Utils and State Report Management should be regrouped to:

Also restore/clear/delete vulnerabilities endpoints should be removed as they cannot be used within the state report management cycle.

AdaptationCordinator should become a Notification endpoint

SIEA group should be absorbed or be wrappers to Notifications/State Report Management calls.

scp93ch commented 1 month ago

Both SSM Utils and State Report Management should be regrouped to:

  • SSM Utils: mainly utility methods generic

    • force adaptor lock remove
    • check model exists
    • validate model
    • jobs (check job status)

  • State Report Management

    • states (get/post/delete)
    • process
    • download
    • delete report

  • Notifications

    • notify openvas report

  • Recommendations

    • recommendations
    • download

  • Plotting

    • path- plot

  • Risk

    • calc-risk

Also restore/clear/delete vulnerabilities endpoints should be removed as they cannot be used within the state report management cycle.

AdaptationCordinator should become a Notification endpoint

SIEA group should be absorbed or be wrappers to Notifications/State Report Management calls.

The grouping looks sensible, thanks. I don't know what the "vulnerabilities endpoints" are. Can we just do the re-grouping here and review other changes separately?

panositi commented 1 month ago

We can add another group e.g. Vulnerabilities Management but that will be confusing.

Normally changes to TWAs for example are recorded and can be reversed by the adaptor. The calls in that group can show the list of the applied TWA changes, that list of changes is cached in the adaptor and can be revoked, or deleted from the cache.

All these calls are related with a workflow execution which the group of state report management handles better. I will group them separetely then.

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
12 Security Hotspots
7.8% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint