Spyderisk / system-modeller

Spyderisk web service and web client
Other
4 stars 4 forks source link

isWorkInProgress and isProposed are added to inferred graph #127

Open scp93ch opened 9 months ago

scp93ch commented 9 months ago

If you select the amber traffic light on a control set, the triple denoting that the CS is core#isWorkInProgress gets added to the asserted and inferred graphs.

If you select the green traffic light on a control set, the triple denoting that the CS is core#isProposed (and the core#isWorkInProgress) gets added to the asserted and inferred graphs.

I think we should not be adding these triples to the inferred graph.

scp93ch commented 9 months ago

@mike1813 what do you think?

mike1813 commented 9 months ago

In principle the triples should be added only to the asserted graph. When you revalidate the inferred graph is dropped anyway, so in practice it makes no difference. A more important aspect is making sure the two properties are consistent across each population triplet. I think @kenmeacham already did some work on this, but I think it was implemented client-side, so it may make sense to do some more work.