SpyglassMC / Spyglass

Development tools for vanilla Minecraft: Java Edition data pack developers.
https://spyglassmc.com
MIT License
277 stars 29 forks source link

Index map issue with nested strings #1296

Closed misode closed 6 days ago

misode commented 4 weeks ago

This needs to be investigated

summon cow ~ ~ ~ {CustomName:'{"text":"hello","hoverEvent":{"action":"show_item","value":"{id:\'acacia_boat\'}"}}'}

image

misode commented 3 weeks ago

I found another case where it went wrong: image Interestingly, it works correctly when using only double quotes: image

TheAfroOfDoom commented 3 weeks ago

from https://github.com/SpyglassMC/Spyglass/pull/1355#issue-2365408905

341597309-396ad3ce-ebfd-4891-b933-55ee4a914c90

this is a log of index maps when the core.string parser (?) is called.

you can see that at some point it's not actually receiving/merging with the old index map properly. i think it should be an ~easy-ish fix just need to figure out exactly where to connect prior index maps to the new one