Warn when using both unnamespaced and namespaced key in a map

[misode]

In the following item modifier, a warning should be reported because attribute_modifiers and minecraft:attribute_modifiers are essentially duplicate keys.

{
  "function": "minecraft:set_components",
  "components": {
    "attribute_modifiers": [],
    "minecraft:attribute_modifiers": []
  }
}

[MulverineX]

Shouldn't this error, not warn?

[misode]

Duplicate keys show a warning in other places

[MulverineX]

That probably shouldn't be the case

[misode]

It is the case with the default json vscode language features, why should we change that?

[MulverineX]

Because it's incredibly silly, and there's probably some JSON deserializers that don't even support it

[NeunEinser]

Hmm, I am also reporting duplicate keys as errors. How does minecraft react to it? I would have assumed it doesn't want to parse it.

[misode]

It depends on the exact case.

• Game accepts the command and just uses the second value: /summon zombie ~ ~ ~ {HandItems:[{id:"golden_sword",components:{"enchantments":{sharpness:4,"minecraft:sharpness":5}}}]}
• Game doesn't accept the command: /give @s minecraft:golden_sword[enchantments={sharpness:4,"minecraft:sharpness":5}]

But there's no need for us to match the game exactly. We can decide ourselves whether something should be a warning or error.