search

SpyglassMC / Spyglass

Development tools for vanilla Minecraft: Java Edition data pack developers.
https://spyglassmc.com
MIT License
281 stars 30 forks source link

More entity type validations #1457

Open tryashtar opened 3 weeks ago

tryashtar commented 3 weeks ago

These commands are invalid:

effect give @e[type=item] slowness
enchant @e[type=item] sharpness
attribute @e[type=item,limit=1] minecraft:generic.armor get
ride @s mount @e[type=marker,limit=1]

I think that's pretty much it for commands that can affect entities, but not all entity types. Spyglass already does a good job pointing out which commands require a player, but it doesn't currently catch any of these.

MulverineX commented 2 weeks ago

We can bootstrap our own manually tracked data for this via ArticData. As for location, I think this would belong in mcdoc via something like a minecraft:entity_feature dispatcher to string unions/enums.