SpyglassMC / Spyglass

Development tools for vanilla Minecraft: Java Edition data pack developers.
https://spyglassmc.com
MIT License
277 stars 29 forks source link

High usage of file system watchers without respect for vscode exclusions #1464

Open MattiDragon opened 1 week ago

MattiDragon commented 1 week ago

The datapack helper extension seems to create a watcher for every file in any open project without respecting the files.watcherExclude option. This leads to hard to debug issues where watcher limits are reached, with no easy way to get any more info than that a vscode nodejs process is at fault. Please find a way to use less watchers, or at least respect the option.

SPGoding commented 1 week ago

For best interoperability of different editors the language server should take a Config argument in initialization options that gets merged with and overrides the default Config (so that settings from the project config file still takes priority). Language clients can then supply this argument during initialization and pass in any editor specific settings that are relavant.