search

SpyglassMC / Spyglass

Development tools for vanilla Minecraft: Java Edition data pack developers.
https://spyglassmc.com
MIT License
273 stars 29 forks source link

Highlight function calls with underline #1475

Open misode opened 4 days ago

misode commented 4 days ago

The previous version underlined the function resource locations. Many people are used to this appearance so we should try to re-add this.

TheAfroOfDoom commented 4 days ago

this being an optional config setting would be nice

SPGoding commented 3 days ago

Resource locations used to be DocumentLinks in v3. They are now handled by go to definition. We could add underline style to the resourceLocation semantic token in package.json in vscode-extention to restore the style without changing how resource locations are supported internally, or provide documentation on how users can override the styles for the semantic tokens in general.

MulverineX commented 3 days ago

IMO we should do both. Change the default to the previous behavior, and make it optional by documenting how to do the style override