search

SpyglassMC / Spyglass

Development tools for vanilla Minecraft: Java Edition data pack developers.
https://spyglassmc.com
MIT License
320 stars 32 forks source link

Proxy for api.github.com #1480

Open SPGoding opened 4 months ago

SPGoding commented 4 months ago

Would hopefully prevent #1466 and any potential rate limit (like this complaint in the Spyglass #general Discord channel from happening.

misode commented 4 months ago

Would it be a good idea to try the actual URL first before falling back to the proxy, to avoid overloading the proxy too much? I have no idea about how many requests it would be getting tbh, so maybe that's not worth the added complexity

MulverineX commented 4 months ago

It's pretty user-dependent so yeah ideally the proxy is a fallback

MulverineX commented 3 months ago

Implementation detail: if an endpoint fails, that shouldn't brick the extension data; in the #1565 case, switching on a VPN didn't load in the data for some reason.

Blackblock-inc commented 3 months ago

Implementation detail: if an endpoint fails, that shouldn't brick the extension data; in the #1565 case, switching on a VPN didn't load in the data for some reason.

uh...So, how should I solve this problem now? Is this my problem? 屏幕截图 2024-08-10 133656

MulverineX commented 3 months ago

@Blackblock-inc I'd recommend posting in the Spyglass Discord server https://discord.gg/EbdseuS where someone can hopefully help you get it working for now